Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Improve Cosmos EndToEnd test #5639

Closed
wants to merge 6 commits into from

Conversation

radical
Copy link
Member

@radical radical commented Sep 10, 2024

Wait for the texts indicating that the db, and service are ready for requests before sending the http request. This helps with unnecessary attempts, and wait times in the retry pipeline.

  • [tests] TestProject.WorkerA - reduce pings logged to every 30s instead of 1s to reduce noise in the logs
  • [tests] TestProject.AppHost - use single line logging to help with matching log texts in the tests
  • [tests] EndToEnd tests - add some text to wait for before sending the http request
Microsoft Reviewers: Open in CodeFlow

@radical radical changed the title improve cosmos e2e test [tests] Improve Cosmos EndToEnd test Sep 10, 2024
@radical
Copy link
Member Author

radical commented Sep 10, 2024

Related: #5641

@radical radical added the area-integrations Issues pertaining to Aspire Integrations packages label Sep 10, 2024
@eerhardt
Copy link
Member

eerhardt commented Sep 10, 2024

What do you think about removing this test from the EndToEnd and putting it in its own FunctionalTests? Like we did for the other integrations. I think this is just left over from that work.

Then we wouldn't need to clutter up the EndToEnd tests with this change.

@radical
Copy link
Member Author

radical commented Sep 10, 2024

What do you think about removing this test from the EndToEnd and putting it in its own FunctionalTests? Like we did for the other integrations. I think this is just left over from that work.

Then we wouldn't need to clutter up the EndToEnd tests with this change.

Makes sense. cc @sebastienros as he has been adding the functional tests.

@radical
Copy link
Member Author

radical commented Sep 11, 2024

Added cosmos to #4741 . Closing this in favor of that issue.

@radical radical closed this Sep 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages testing ☑️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants